Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize hover value experience #139

Merged
merged 3 commits into from
Sep 8, 2020
Merged

chore: optimize hover value experience #139

merged 3 commits into from
Sep 8, 2020

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Sep 7, 2020

添加防抖,优化 Firefox 浏览器体验。

@vercel
Copy link

vercel bot commented Sep 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/picker/avofuc3be
✅ Preview: https://picker-git-fork-kermit-xuan-optimize-hover-value.react-component.vercel.app

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #139 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          45       45           
  Lines        1980     1989    +9     
  Branches      581      590    +9     
=======================================
+ Hits         1972     1981    +9     
  Misses          6        6           
  Partials        2        2           
Impacted Files Coverage Δ
src/RangePicker.tsx 100.00% <100.00%> (ø)
src/hooks/useHoverValue.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335ddfc...30c2f26. Read the comment docs.

@kerm1it
Copy link
Member Author

kerm1it commented Sep 7, 2020

@afc163 试试这个效果怎么样?

@afc163
Copy link
Member

afc163 commented Sep 7, 2020

没合并到 antd 貌似看不太出来效果。

@kerm1it
Copy link
Member Author

kerm1it commented Sep 7, 2020

用这个预览链接看不出效果么?

@kerm1it
Copy link
Member Author

kerm1it commented Sep 7, 2020

我在我本地打包,放到 antd 里面试了一下,好像好了,你在你本地试试。

@afc163
Copy link
Member

afc163 commented Sep 8, 2020

本地测了一下好多了。

@afc163
Copy link
Member

afc163 commented Sep 8, 2020

image

@kerm1it kerm1it changed the title Optimize hover value chore: optimize hover value experience Sep 8, 2020
@kerm1it kerm1it merged commit d26758a into react-component:master Sep 8, 2020
@kerm1it kerm1it deleted the optimize-hover-value branch September 8, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants